Correct treesit-mode requirement to Emacs 29.1#202
Merged
Conversation
`gdscript-ts-mode` makes use of `font-lock-function-call-face` which was only introduced in version 29.1. As such it would not highlight function calls correctly on lower versions. (and presumably throw a warning for a void symbol)
Collaborator
|
Can you also change the required Emacs version in the Eask file? Thank you! |
jcs090218
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gdscript-ts-modeusesfont-lock-function-call-facewhich was only introduced in version 29.1.emacs-gdscript-mode/gdscript-ts-mode.el
Lines 177 to 179 in 55c9b1d
It won't highlight function calls correctly on lower versions. Also since
treesitis a29.1feature, the mode is basically useless on lower versions anyway.